Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sanity failure #77

Merged
merged 3 commits into from
Apr 5, 2021
Merged

Fix sanity failure #77

merged 3 commits into from
Apr 5, 2021

Conversation

gravesm
Copy link
Member

@gravesm gravesm commented Apr 1, 2021

SUMMARY

This fixes a sanity test failure for newer versions of ansible-test. It
was falsely flagging the key parameter for TLS configuration as
sensitive. This parameter is just the path to a key file.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

openshift_route

ADDITIONAL INFORMATION

This fixes a sanity test failure for newer versions of ansible-test. It
was falsely flagging the key parameter for TLS configuration as
sensitive. This parameter is just the path to a key file.
@fabianvf
Copy link
Member

fabianvf commented Apr 1, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2021
This is needed to address a breaking change in molecule 3.3.0.
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2021
@gravesm
Copy link
Member Author

gravesm commented Apr 1, 2021

/retest

@Akasurde
Copy link
Contributor

Akasurde commented Apr 5, 2021

LGTM

@gravesm
Copy link
Member Author

gravesm commented Apr 5, 2021

/retest

@Akasurde
Copy link
Contributor

Akasurde commented Apr 5, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 5, 2021
@Akasurde
Copy link
Contributor

Akasurde commented Apr 5, 2021

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Akasurde, gravesm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2021
@openshift-merge-robot openshift-merge-robot merged commit e7e1147 into openshift:main Apr 5, 2021
@gravesm gravesm deleted the no-log branch May 26, 2021 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants